Create Docker image for Python auto-instrumentation. #524
Conversation
|
and @owais I guess this one you might be particularly interested in ;) |
anuraaga
force-pushed
the
autopython-docker
branch
from
06933bf
to
0e03c51
Compare
| @@ -0,0 +1,43 @@ | |||
| opentelemetry-distro==0.25b2 | |||
| # We don't use the distro[otlp] option which automatically includes exporters since gRPC is not appropriate for | |||
There was a problem hiding this comment.
I made this decision, but not sure on it. @owais In particular perhaps you have some advice on what we should use here in our "autoinstrumentation distro". The somewhat annoying aspect is that the operator will have to handle the OTEL_TRACES_EXPORTER for the user. But the alternative seems to be publishing an image per python version, which yikes.
There was a problem hiding this comment.
I think using proto http sounds reasonable if you can get away with it. I was working on a similar feature at some point and had decided to build one image per platform/architecture.
|
|
||
| RUN mkdir workspace && pip install --target workspace -r requirements.txt | ||
|
|
||
| FROM busybox |
There was a problem hiding this comment.
I was wondering why we are using busybox as a base image. Other operator images are based on gcr.io/distroless/static:nonroot. If there is no reason I would prefer to be consistent.
There was a problem hiding this comment.
The distroless image doesn't contain the cp command which we need.
|
e2e in #532 will fail until this is merged |
|
Don't think anything is blocking this - hopefully can merge and I'll wrap up 532 |
Created https://github.com/anuraaga/opentelemetry-operator/pkgs/container/opentelemetry-operator%2Fautoinstrumentation-python with it
I will write up the PR for the operator change after #507 is in. The mechanism, which I verified locally, is
PYTHONPATH=/otel-autoinstrumentation/opentelemetry/instrumentation/auto_instrumentation:$PYTHONPATH:/otel-autoinstrumentationThe trick is that the first entry is pointing to the folder with OTel's
sitecustomize.pywhich gets automatically executed.This is the same as what the
opentelemetry-instrumentscript does I think except also appends the opentelemetry libraries to pythonpath, which otherwise is usually pip installed.https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/opentelemetry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/__init__.py#L105