Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit names and labels to 63 characters #609

Conversation

mmatache
Copy link
Contributor

@mmatache mmatache commented Dec 7, 2021

Issue: #596

Used Jaeger truncating and DNS functions to format names and labels of created items.
Links to code:

@mmatache mmatache requested review from a team and dmitryax December 7, 2021 10:15
@jpkrohling
Copy link
Member

@VineethReddy02, would you be able to review this one?

Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

@jpkrohling jpkrohling merged commit d2b91cf into open-telemetry:main Dec 8, 2021
@mmatache
Copy link
Contributor Author

mmatache commented Dec 8, 2021

Thank you for the merge!
@jpkrohling quick question, when can I expect a release with this fix to be available in a release?

shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
* added naming formaters from jaeger project

* updated naming to use name formatters

* update labels to conform with kubernetes rules

* fixed linting issues

* added Jaeger copyright

* updated Jaeger copyright
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* added naming formaters from jaeger project

* updated naming to use name formatters

* update labels to conform with kubernetes rules

* fixed linting issues

* added Jaeger copyright

* updated Jaeger copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants