Add OpenTelemetryCollector.Spec.UpgradeStrategy #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I still want to look at this a little further, and double check a few things (are there enough tests?), but figured I'd throw a draft PR out there with this idea to get any feedback) |
adriankostrubiak-tomtom
force-pushed
the
add-otc-spec-upgradestrategy
branch
from
913738d
to
c0a47d6
Compare
…: 'automatic', 'none' fixes open-telemetry#598 Signed-off-by: Adrian Kostrubiak adrian.kostrubiak@tomtom.com lint Add read permissions to other users for instrumentation files (open-telemetry#622) * Add read permissions to other users for instrumentation files Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * revert Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> PR feedback; adjust test suites to start up / spin down webhook server so that defaulting works as expected. TODO for another time to extract much of the duplicated logic across the varying suite_test.go TestMain funcs
adriankostrubiak-tomtom
force-pushed
the
add-otc-spec-upgradestrategy
branch
from
c0a47d6
to
11d7f9e
Compare
jpkrohling
reviewed
Dec 10, 2021
jpkrohling
approved these changes
Dec 10, 2021
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add OpenTelemetryCollector.Spec.UpgradeStrategy with allowable values: 'automatic', 'none' fixes open-telemetry#598 Signed-off-by: Adrian Kostrubiak adrian.kostrubiak@tomtom.com lint Add read permissions to other users for instrumentation files (open-telemetry#622) * Add read permissions to other users for instrumentation files Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * revert Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> PR feedback; adjust test suites to start up / spin down webhook server so that defaulting works as expected. TODO for another time to extract much of the duplicated logic across the varying suite_test.go TestMain funcs * adjust docs per PR comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OpenTelemetryCollector.Spec.UpgradeStrategy with allowable values:
automatic,nonefixes #598
Signed-off-by: Adrian Kostrubiak adrian.kostrubiak@tomtom.com