Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeIgniter 4.0+ auto-instrumentation (root span) #201

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

agoallikmaa
Copy link
Contributor

Implements CodeIgniter 4.0+ auto-instrumentation (open-telemetry/opentelemetry-auto-codeigniter package). Currently only collects root span.

@agoallikmaa agoallikmaa requested a review from a team October 9, 2023 21:53
@welcome
Copy link

welcome bot commented Oct 9, 2023

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #201 (983bf86) into main (897ad76) will decrease coverage by 1.16%.
The diff coverage is 0.00%.

❗ Current head 983bf86 differs from pull request most recent head 9e5c04a. Consider uploading reports for the commit 9e5c04a to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #201      +/-   ##
============================================
- Coverage     34.28%   33.13%   -1.16%     
- Complexity      824      852      +28     
============================================
  Files            73       76       +3     
  Lines          3138     3247     +109     
============================================
  Hits           1076     1076              
- Misses         2062     2171     +109     
Flag Coverage Δ
7.4 45.94% <ø> (-0.40%) ⬇️
8.0 32.94% <0.00%> (-1.38%) ⬇️
8.1 33.10% <0.00%> (-1.25%) ⬇️
8.2 33.08% <0.00%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ation/CodeIgniter/src/RequestPropagationGetter.php 0.00% <0.00%> (ø)
...tion/CodeIgniter/src/ResponsePropagationSetter.php 0.00% <0.00%> (ø)
...ion/CodeIgniter/src/CodeIgniterInstrumentation.php 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897ad76...9e5c04a. Read the comment docs.

@brettmc
Copy link
Collaborator

brettmc commented Oct 10, 2023

Hi @agoallikmaa
Thanks for your contribution, this looks good.
Can you please also update:

  • .github/workflows/php.yml (add to build matrix)
  • .gitsplit.yaml (to enable git split to a readonly repo that packagist can reference)

@brettmc
Copy link
Collaborator

brettmc commented Oct 11, 2023

Sorry, I was referring to the changes in #200 which I thought had already been merged (as discussed in SIG just now)

@brettmc brettmc merged commit c9ed6b0 into open-telemetry:main Oct 17, 2023
@brettmc
Copy link
Collaborator

brettmc commented Oct 17, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants