-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TraceAttributes
to semconv to 1.22.0
#204
Update TraceAttributes
to semconv to 1.22.0
#204
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Thanks, @julianocosta89 - I've just noticed that I only check for removed |
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
=========================================
Coverage 33.13% 33.13%
Complexity 852 852
=========================================
Files 76 76
Lines 3247 3247
=========================================
Hits 1076 1076
Misses 2171 2171
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Thanks @brettmc! It seems that there are other attributes that need to be updated, I'll take care of that |
Just one attribute that I couldn't find: I've replaced with |
@brettmc and @pdelewski I've updated a bunch of other TraceAttributes after your review, would you mind double checking it? Appreciate the help! |
HTTP_FLAVOR
with NETWORK_PROTOCOL_VERSION
TraceAttributes
to semconv to 1.22.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I've tagged new versions of the updated packages. Thanks, @julianocosta89 |
After PR open-telemetry/opentelemetry-php#1126 got merged,
HTTP_FLAVOR
was dropped and all the instrumentations that used it started failing.This PR updates
TraceAttributes::HTTP_FLAVOR
toTraceAttributes::NETWORK_PROTOCOL_VERSION
.