guzzle auto-instrumentation #226
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
============================================
- Coverage 85.83% 85.61% -0.22%
- Complexity 917 929 +12
============================================
Files 83 85 +2
Lines 3684 3754 +70
============================================
+ Hits 3162 3214 +52
- Misses 522 540 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
| "ext-opentelemetry": "*", | ||
| "ext-reflection": "*", | ||
| "open-telemetry/api": "^1.0", | ||
| "open-telemetry/sem-conv": "^1.22", |
There was a problem hiding this comment.
The current package is in version 1.23.1 of the semantic convention, what do you think of the package starting from this version?
If you see that it makes sense, I believe that a separate PR can be opened to update the other packages to this version, since everyone is using version ^1.22.
| "open-telemetry/sem-conv": "^1.22", | |
| "open-telemetry/sem-conv": "^1.23", |
There was a problem hiding this comment.
I think it's a good idea to do a separate PR to update everything to 1.23
|
Some uncaught Phan exceptions; this expected? |
No. I added 8.3 to the build matrix and most jobs seem unhappy with it. I'll tackle that as a separate PR... |
Fixes: open-telemetry/opentelemetry-php#1204