Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added schema URL for all packages lower than 1.0.0 #273

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 10.34483% with 26 lines in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (ac524f9) to head (284117b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #273      +/-   ##
============================================
- Coverage     83.53%   82.65%   -0.88%     
+ Complexity     1057      997      -60     
============================================
  Files           104       97       -7     
  Lines          4392     4025     -367     
============================================
- Hits           3669     3327     -342     
+ Misses          723      698      -25     
Flag Coverage Δ
Aws:7.4 ?
Aws:8.0 85.75% <ø> (ø)
Aws:8.1 ?
Aws:8.2 85.75% <ø> (ø)
Aws:8.3 ?
Context/Swoole:7.4 0.00% <ø> (ø)
Context/Swoole:8.0 0.00% <ø> (ø)
Context/Swoole:8.1 0.00% <ø> (ø)
Context/Swoole:8.2 ?
Context/Swoole:8.3 ?
Instrumentation/CakePHP:8.0 ?
Instrumentation/CakePHP:8.1 ?
Instrumentation/CakePHP:8.2 ?
Instrumentation/CakePHP:8.3 87.75% <0.00%> (-5.73%) ⬇️
Instrumentation/CodeIgniter:8.0 ?
Instrumentation/CodeIgniter:8.1 ?
Instrumentation/CodeIgniter:8.2 ?
Instrumentation/CodeIgniter:8.3 73.94% <0.00%> (-1.92%) ⬇️
Instrumentation/ExtAmqp:8.2 89.58% <0.00%> (ø)
Instrumentation/ExtAmqp:8.3 89.58% <0.00%> (ø)
Instrumentation/Guzzle:8.0 ?
Instrumentation/Guzzle:8.1 ?
Instrumentation/Guzzle:8.2 ?
Instrumentation/Guzzle:8.3 ?
Instrumentation/HttpAsyncClient:8.0 ?
Instrumentation/HttpAsyncClient:8.1 ?
Instrumentation/HttpAsyncClient:8.2 ?
Instrumentation/HttpAsyncClient:8.3 ?
Instrumentation/IO:8.2 ?
Instrumentation/IO:8.3 ?
Instrumentation/Laravel:8.0 ?
Instrumentation/Laravel:8.1 64.86% <0.00%> (-0.35%) ⬇️
Instrumentation/Laravel:8.2 64.86% <0.00%> (-0.35%) ⬇️
Instrumentation/Laravel:8.3 64.86% <0.00%> (-0.35%) ⬇️
Instrumentation/MongoDB:7.4 ?
Instrumentation/MongoDB:8.0 ?
Instrumentation/MongoDB:8.1 ?
Instrumentation/MongoDB:8.2 77.33% <0.00%> (-3.23%) ⬇️
Instrumentation/MongoDB:8.3 77.33% <0.00%> (-3.23%) ⬇️
Instrumentation/OpenAIPHP:8.1 86.82% <100.00%> (ø)
Instrumentation/OpenAIPHP:8.2 ?
Instrumentation/OpenAIPHP:8.3 ?
Instrumentation/PDO:8.2 ?
Instrumentation/PDO:8.3 ?
Instrumentation/Psr14:8.0 ?
Instrumentation/Psr14:8.1 78.12% <0.00%> (-2.53%) ⬇️
Instrumentation/Psr14:8.2 ?
Instrumentation/Psr14:8.3 ?
Instrumentation/Psr15:8.0 ?
Instrumentation/Psr15:8.1 93.50% <ø> (ø)
Instrumentation/Psr15:8.2 93.50% <ø> (ø)
Instrumentation/Psr15:8.3 ?
Instrumentation/Psr16:8.0 97.50% <100.00%> (ø)
Instrumentation/Psr16:8.1 ?
Instrumentation/Psr16:8.2 ?
Instrumentation/Psr16:8.3 97.50% <100.00%> (ø)
Instrumentation/Psr18:8.0 ?
Instrumentation/Psr18:8.1 82.08% <ø> (ø)
Instrumentation/Psr18:8.2 82.08% <ø> (ø)
Instrumentation/Psr18:8.3 ?
Instrumentation/Psr3:8.0 ?
Instrumentation/Psr3:8.1 ?
Instrumentation/Psr3:8.2 61.03% <0.00%> (-2.48%) ⬇️
Instrumentation/Psr3:8.3 ?
Instrumentation/Psr6:8.0 ?
Instrumentation/Psr6:8.1 ?
Instrumentation/Psr6:8.2 97.61% <100.00%> (ø)
Instrumentation/Psr6:8.3 97.61% <100.00%> (ø)
Instrumentation/Slim:8.0 ?
Instrumentation/Slim:8.1 ?
Instrumentation/Slim:8.2 86.95% <ø> (ø)
Instrumentation/Slim:8.3 ?
Instrumentation/Symfony:8.0 ?
Instrumentation/Symfony:8.1 ?
Instrumentation/Symfony:8.2 ?
Instrumentation/Symfony:8.3 92.55% <ø> (-2.29%) ⬇️
Instrumentation/Yii:8.0 ?
Instrumentation/Yii:8.1 ?
Instrumentation/Yii:8.2 ?
Instrumentation/Yii:8.3 77.77% <0.00%> (-2.05%) ⬇️
Logs/Monolog:7.4 ?
Logs/Monolog:8.0 ?
Logs/Monolog:8.1 ?
Logs/Monolog:8.2 100.00% <ø> (ø)
Logs/Monolog:8.3 100.00% <ø> (ø)
Propagation/ServerTiming:8.0 ?
Propagation/ServerTiming:8.1 ?
Propagation/ServerTiming:8.2 100.00% <ø> (ø)
Propagation/ServerTiming:8.3 100.00% <ø> (ø)
Propagation/TraceResponse:7.4 100.00% <ø> (ø)
Propagation/TraceResponse:8.0 ?
Propagation/TraceResponse:8.1 100.00% <ø> (ø)
Propagation/TraceResponse:8.2 ?
Propagation/TraceResponse:8.3 ?
ResourceDetectors/Azure:7.4 ?
ResourceDetectors/Azure:8.0 ?
ResourceDetectors/Azure:8.1 ?
ResourceDetectors/Azure:8.2 91.66% <ø> (ø)
ResourceDetectors/Azure:8.3 91.66% <ø> (ø)
ResourceDetectors/Container:8.0 93.02% <ø> (ø)
ResourceDetectors/Container:8.1 ?
ResourceDetectors/Container:8.2 ?
ResourceDetectors/Container:8.3 93.02% <ø> (ø)
Shims/OpenTracing:7.4 ?
Shims/OpenTracing:8.0 ?
Shims/OpenTracing:8.1 ?
Shims/OpenTracing:8.2 92.99% <ø> (ø)
Shims/OpenTracing:8.3 ?
Symfony:7.4 88.43% <ø> (ø)
Symfony:8.0 88.20% <ø> (ø)
Symfony:8.1 ?
Symfony:8.2 88.20% <ø> (ø)
Symfony:8.3 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntation/OpenAIPHP/src/OpenAIPHPInstrumentation.php 86.82% <100.00%> (ø)
...Instrumentation/Psr16/src/Psr16Instrumentation.php 97.50% <100.00%> (ø)
...c/Instrumentation/Psr6/src/Psr6Instrumentation.php 97.61% <100.00%> (ø)
...rumentation/ExtAmqp/src/ExtAmqpInstrumentation.php 89.58% <0.00%> (ø)
...Instrumentation/Psr14/src/Psr14Instrumentation.php 78.12% <0.00%> (-2.53%) ⬇️
...rumentation/CakePHP/src/CakePHPInstrumentation.php 87.75% <0.00%> (-5.73%) ⬇️
...ion/CodeIgniter/src/CodeIgniterInstrumentation.php 79.04% <0.00%> (-2.33%) ⬇️
...rumentation/Laravel/src/LaravelInstrumentation.php 0.00% <0.00%> (ø)
...rumentation/MongoDB/src/MongoDBInstrumentation.php 22.22% <0.00%> (-11.12%) ⬇️
...c/Instrumentation/Psr3/src/Psr3Instrumentation.php 49.15% <0.00%> (-2.64%) ⬇️
... and 1 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac524f9...284117b. Read the comment docs.

@brettmc
Copy link
Collaborator

brettmc commented Jun 21, 2024

I had understood in open-telemetry/opentelemetry-php#1312 (comment) that we should update to the latest semantic version which is currently 1.25.

I did say latest in that comment, but in a subsequent discussion (it might have been at SIG), we decided that we should favour getting a 1.0 release of all auto-instrumentation modules with 8.0 support, if possible. Going with semconv 1.25 would block 8.0.

@weslenteche
Copy link
Contributor Author

I did say latest in that comment, but in a subsequent discussion (it might have been at SIG), we decided that we should favour getting a 1.0 release of all auto-instrumentation modules with 8.0 support, if possible. Going with semconv 1.25 would block 8.0.

Thank you for clarifying my doubt

@brettmc
Copy link
Collaborator

brettmc commented Jun 22, 2024

LGTM 👍

@weslenteche weslenteche marked this pull request as ready for review June 22, 2024 12:45
@weslenteche weslenteche requested review from a team and ChrisLightfootWild June 22, 2024 12:45
@brettmc brettmc merged commit c937e29 into open-telemetry:main Jun 25, 2024
114 of 115 checks passed
@weslenteche weslenteche deleted the add-schema-url branch June 25, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants