Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Record handled exceptions #280

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

cedricziel
Copy link
Contributor

This change records exceptions even if they are handled by the Kernel.

This is handy for apps that have an error handler registered.

This change records exceptions even if they are handled by the Kernel.

This is handy for apps that have an error handler registered.
@cedricziel cedricziel requested a review from a team July 11, 2024 20:58
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (c22df17) to head (406ff50).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #280      +/-   ##
============================================
- Coverage     82.64%   82.45%   -0.20%     
  Complexity     1073     1073              
============================================
  Files           104      104              
  Lines          4461     4480      +19     
============================================
+ Hits           3687     3694       +7     
- Misses          774      786      +12     
Flag Coverage Δ
Aws:7.4 86.02% <ø> (ø)
Aws:8.0 85.75% <ø> (ø)
Aws:8.1 85.75% <ø> (ø)
Aws:8.2 85.75% <ø> (ø)
Aws:8.3 85.75% <ø> (ø)
Context/Swoole:7.4 0.00% <ø> (ø)
Context/Swoole:8.0 0.00% <ø> (ø)
Context/Swoole:8.1 0.00% <ø> (ø)
Context/Swoole:8.2 0.00% <ø> (ø)
Context/Swoole:8.3 0.00% <ø> (ø)
Instrumentation/CakePHP:8.0 ?
Instrumentation/CakePHP:8.1 87.75% <ø> (ø)
Instrumentation/CakePHP:8.2 87.75% <ø> (ø)
Instrumentation/CakePHP:8.3 87.75% <ø> (ø)
Instrumentation/CodeIgniter:8.0 ?
Instrumentation/CodeIgniter:8.1 73.94% <ø> (ø)
Instrumentation/CodeIgniter:8.2 73.94% <ø> (ø)
Instrumentation/CodeIgniter:8.3 73.94% <ø> (ø)
Instrumentation/ExtAmqp:8.2 89.58% <ø> (ø)
Instrumentation/ExtAmqp:8.3 89.58% <ø> (ø)
Instrumentation/Guzzle:8.0 69.73% <ø> (ø)
Instrumentation/Guzzle:8.1 ?
Instrumentation/Guzzle:8.2 69.73% <ø> (ø)
Instrumentation/Guzzle:8.3 69.73% <ø> (ø)
Instrumentation/HttpAsyncClient:8.0 81.33% <ø> (ø)
Instrumentation/HttpAsyncClient:8.1 81.33% <ø> (ø)
Instrumentation/HttpAsyncClient:8.2 81.33% <ø> (ø)
Instrumentation/HttpAsyncClient:8.3 81.33% <ø> (ø)
Instrumentation/IO:8.2 70.90% <ø> (ø)
Instrumentation/IO:8.3 70.90% <ø> (ø)
Instrumentation/Laravel:8.0 64.86% <ø> (ø)
Instrumentation/Laravel:8.1 64.86% <ø> (ø)
Instrumentation/Laravel:8.2 64.86% <ø> (ø)
Instrumentation/Laravel:8.3 64.86% <ø> (ø)
Instrumentation/MongoDB:7.4 77.33% <ø> (ø)
Instrumentation/MongoDB:8.0 77.33% <ø> (ø)
Instrumentation/OpenAIPHP:8.1 86.82% <ø> (ø)
Instrumentation/OpenAIPHP:8.2 86.82% <ø> (ø)
Instrumentation/OpenAIPHP:8.3 86.82% <ø> (ø)
Instrumentation/PDO:8.2 89.56% <ø> (ø)
Instrumentation/PDO:8.3 89.56% <ø> (ø)
Instrumentation/Psr14:8.0 78.12% <ø> (ø)
Instrumentation/Psr14:8.1 78.12% <ø> (ø)
Instrumentation/Psr14:8.2 78.12% <ø> (ø)
Instrumentation/Psr14:8.3 78.12% <ø> (ø)
Instrumentation/Psr15:8.0 93.50% <ø> (ø)
Instrumentation/Psr15:8.1 93.50% <ø> (ø)
Instrumentation/Psr15:8.2 93.50% <ø> (ø)
Instrumentation/Psr15:8.3 93.50% <ø> (ø)
Instrumentation/Psr16:8.0 ?
Instrumentation/Psr16:8.1 97.50% <ø> (ø)
Instrumentation/Psr16:8.2 97.50% <ø> (ø)
Instrumentation/Psr16:8.3 97.50% <ø> (ø)
Instrumentation/Psr18:8.0 82.08% <ø> (ø)
Instrumentation/Psr18:8.1 ?
Instrumentation/Psr18:8.2 82.08% <ø> (ø)
Instrumentation/Psr18:8.3 82.08% <ø> (ø)
Instrumentation/Psr3:8.0 61.03% <ø> (ø)
Instrumentation/Psr3:8.1 61.03% <ø> (ø)
Instrumentation/Psr3:8.2 61.03% <ø> (ø)
Instrumentation/Psr3:8.3 61.03% <ø> (ø)
Instrumentation/Psr6:8.0 97.61% <ø> (ø)
Instrumentation/Psr6:8.1 97.61% <ø> (ø)
Instrumentation/Psr6:8.2 97.61% <ø> (ø)
Instrumentation/Psr6:8.3 97.61% <ø> (ø)
Instrumentation/Slim:8.0 86.23% <ø> (ø)
Instrumentation/Slim:8.1 ?
Instrumentation/Slim:8.2 86.95% <ø> (ø)
Instrumentation/Slim:8.3 86.95% <ø> (ø)
Instrumentation/Symfony:8.0 89.03% <36.84%> (-3.52%) ⬇️
Instrumentation/Symfony:8.1 89.03% <36.84%> (-3.52%) ⬇️
Instrumentation/Symfony:8.2 89.03% <36.84%> (-3.52%) ⬇️
Instrumentation/Symfony:8.3 89.03% <36.84%> (-3.52%) ⬇️
Instrumentation/Yii:8.0 77.77% <ø> (ø)
Instrumentation/Yii:8.1 77.77% <ø> (ø)
Instrumentation/Yii:8.2 77.77% <ø> (ø)
Instrumentation/Yii:8.3 77.77% <ø> (ø)
Logs/Monolog:7.4 100.00% <ø> (ø)
Logs/Monolog:8.0 100.00% <ø> (ø)
Logs/Monolog:8.1 100.00% <ø> (ø)
Logs/Monolog:8.2 100.00% <ø> (ø)
Logs/Monolog:8.3 100.00% <ø> (ø)
Propagation/ServerTiming:8.0 100.00% <ø> (ø)
Propagation/ServerTiming:8.1 100.00% <ø> (ø)
Propagation/ServerTiming:8.2 100.00% <ø> (ø)
Propagation/ServerTiming:8.3 100.00% <ø> (ø)
Propagation/TraceResponse:7.4 100.00% <ø> (ø)
Propagation/TraceResponse:8.0 100.00% <ø> (ø)
Propagation/TraceResponse:8.1 100.00% <ø> (ø)
Propagation/TraceResponse:8.2 100.00% <ø> (ø)
Propagation/TraceResponse:8.3 100.00% <ø> (ø)
ResourceDetectors/Azure:7.4 91.66% <ø> (ø)
ResourceDetectors/Azure:8.0 91.66% <ø> (ø)
ResourceDetectors/Azure:8.1 91.66% <ø> (ø)
ResourceDetectors/Azure:8.2 91.66% <ø> (ø)
ResourceDetectors/Azure:8.3 91.66% <ø> (ø)
ResourceDetectors/Container:8.0 93.02% <ø> (ø)
ResourceDetectors/Container:8.1 93.02% <ø> (ø)
ResourceDetectors/Container:8.2 93.02% <ø> (ø)
ResourceDetectors/Container:8.3 93.02% <ø> (ø)
Shims/OpenTracing:7.4 92.99% <ø> (ø)
Shims/OpenTracing:8.0 92.99% <ø> (ø)
Shims/OpenTracing:8.1 92.99% <ø> (ø)
Shims/OpenTracing:8.2 92.99% <ø> (ø)
Shims/OpenTracing:8.3 92.99% <ø> (ø)
Symfony:7.4 88.43% <ø> (ø)
Symfony:8.0 88.20% <ø> (ø)
Symfony:8.1 88.20% <ø> (ø)
Symfony:8.2 88.20% <ø> (ø)
Symfony:8.3 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rumentation/Symfony/src/SymfonyInstrumentation.php 84.90% <36.84%> (-10.50%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22df17...406ff50. Read the comment docs.

@brettmc brettmc merged commit c701e16 into open-telemetry:main Jul 11, 2024
111 of 115 checks passed
@cedricziel cedricziel deleted the symfony-exception branch July 12, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants