wip: capture spans for controllers automatically #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricziel
force-pushed
the
trace-controller
branch
from
a0dfbe3 to
8cd1747
Compare
brettmc
reviewed
Jul 12, 2024
| if (\strpos($controllerName, '::') > 0) { | ||
| list($class, $method) = \explode('::', $controllerName); | ||
| if (isset($class, $method)) { | ||
| hook( |
There was a problem hiding this comment.
I don't think this will work with modern runtimes, where one long-lived application might handle many requests.
Maybe it should just manually create and end span on Symfony events?
There was a problem hiding this comment.
I think I'd rather memoize the hooks already in place. - this hook in particular is for the controller callable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.