Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure zipkin tags and attributes are cast to strings #1406

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Oct 16, 2024

Closes: #1404

@brettmc brettmc requested a review from a team as a code owner October 16, 2024 00:22
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for opentelemetry-php canceled.

Name Link
🔨 Latest commit f6030dd
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/670f074c8ec0f30008b47d6d

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.77%. Comparing base (2c1da9a) to head (f6030dd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1406      +/-   ##
============================================
+ Coverage     73.68%   73.77%   +0.09%     
  Complexity     2682     2682              
============================================
  Files           387      387              
  Lines          7672     7672              
============================================
+ Hits           5653     5660       +7     
+ Misses         2019     2012       -7     
Flag Coverage Δ
8.1 73.41% <100.00%> (+0.01%) ⬆️
8.2 73.73% <100.00%> (+0.11%) ⬆️
8.3 73.63% <100.00%> (ø)
8.4 73.65% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Contrib/Zipkin/SpanConverter.php 97.16% <100.00%> (+0.70%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1da9a...f6030dd. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 01d0fd3 into open-telemetry:main Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants