-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support refactored otlp export config #1477
support refactored otlp export config #1477
Conversation
upstream config now splits otlp exporters into otlp_http and otlp_grpc
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1477 +/- ##
============================================
- Coverage 72.25% 71.21% -1.04%
- Complexity 2730 2745 +15
============================================
Files 401 404 +3
Lines 8148 8272 +124
============================================
+ Hits 5887 5891 +4
- Misses 2261 2381 +120
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -44,12 +44,14 @@ | |||
"open-telemetry/exporter-otlp": "1.0.x-dev", | |||
"open-telemetry/exporter-zipkin": "1.0.x-dev", | |||
"open-telemetry/extension-propagator-b3": "1.0.x-dev", | |||
"open-telemetry/extension-propagator-cloudtrace": "1.0.x-dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated but noticed when adding transport-grpc
What are the ramifications of this on configurations of existing deployments? If this is released as a non-major version of |
src/Config/SDK/ComponentProvider/Logs/LogRecordExporterOtlpHttp.php
Outdated
Show resolved
Hide resolved
src/Config/SDK/ComponentProvider/Logs/LogRecordExporterOtlpHttp.php
Outdated
Show resolved
Hide resolved
src/Config/SDK/ComponentProvider/Logs/LogRecordExporterOtlpHttp.php
Outdated
Show resolved
Hide resolved
src/Config/SDK/ComponentProvider/Logs/LogRecordExporterOtlpHttp.php
Outdated
Show resolved
Hide resolved
src/Config/SDK/ComponentProvider/Logs/LogRecordExporterOtlpHttp.php
Outdated
Show resolved
Hide resolved
It would break for those using the configuration module. But, it's still at version |
Co-authored-by: Tobias Bachert <git@b-privat.de>
upstream config now splits otlp exporters into otlp_http and otlp_grpc
Reference: open-telemetry/opentelemetry-configuration#146