Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete TODO for addLazyEvent #168

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Remove obsolete TODO for addLazyEvent #168

merged 1 commit into from
Aug 25, 2020

Conversation

arminru
Copy link
Member

@arminru arminru commented Aug 24, 2020

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #168 into master will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #168      +/-   ##
============================================
+ Coverage     90.52%   90.93%   +0.41%     
  Complexity      285      285              
============================================
  Files            35       35              
  Lines           665      662       -3     
============================================
  Hits            602      602              
+ Misses           63       60       -3     
Impacted Files Coverage Δ Complexity Δ
sdk/Metrics/ValueRecorder.php 87.50% <0.00%> (+3.50%) 10.00% <0.00%> (ø%)
sdk/Metrics/UpDownCounter.php 63.63% <0.00%> (+5.30%) 5.00% <0.00%> (ø%)
sdk/Metrics/Counter.php 83.33% <0.00%> (+6.41%) 5.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4100e7a...3d6b9c8. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 9441d1a into open-telemetry:master Aug 25, 2020
@arminru arminru deleted the patch-1 branch August 25, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants