-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow decoration of zipkin span converter #608
Conversation
|
@cdaguerre - I think there are just some phan fixes necessary in the CI and then I believe we'll be good to go here! |
Those phan issues are fixed upstream now, so just merging upstream/main into your branch should make everything green |
I pulled down your branch locally and validated - removing the 4 phpstan annotations around the errored lines let phpstan pass in this PR. That should be all we need to change for this PR to turn green I think. |
@cdaguerre - would you like to make those PHP stan annotation fixes so we can merge this PR? |
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
=========================================
Coverage 84.28% 84.28%
Complexity 1153 1153
=========================================
Files 128 128
Lines 2788 2788
=========================================
Hits 2350 2350
Misses 438 438
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
No description provided.