Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SpanExporter::export() return value to boolean #827

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Sep 17, 2022

Resolves #796.

@Nevay Nevay requested a review from a team September 17, 2022 18:59
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #827 (812bf49) into main (b551294) will increase coverage by 0.00%.
The diff coverage is 97.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #827   +/-   ##
=========================================
  Coverage     82.57%   82.57%           
- Complexity     1884     1885    +1     
=========================================
  Files           231      231           
  Lines          4901     4902    +1     
=========================================
+ Hits           4047     4048    +1     
  Misses          854      854           
Flag Coverage Δ
7.4 82.58% <97.43%> (+<0.01%) ⬆️
8.0 82.61% <97.43%> (+<0.01%) ⬆️
8.1 82.61% <97.43%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Contrib/OtlpHttp/Exporter.php 83.67% <80.00%> (ø)
src/Contrib/Jaeger/AgentExporter.php 100.00% <100.00%> (ø)
src/Contrib/Jaeger/HttpCollectorExporter.php 58.33% <100.00%> (ø)
src/Contrib/Newrelic/Exporter.php 96.66% <100.00%> (ø)
src/Contrib/OtlpGrpc/Exporter.php 91.17% <100.00%> (ø)
src/Contrib/Zipkin/Exporter.php 100.00% <100.00%> (ø)
src/Contrib/ZipkinToNewrelic/Exporter.php 95.83% <100.00%> (ø)
.../SDK/Trace/Behavior/SpanExporterDecoratorTrait.php 100.00% <100.00%> (ø)
src/SDK/Trace/Behavior/SpanExporterTrait.php 100.00% <100.00%> (ø)
src/SDK/Trace/SpanExporter/ConsoleSpanExporter.php 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b551294...812bf49. Read the comment docs.

@brettmc brettmc merged commit 15ebaeb into open-telemetry:main Sep 18, 2022
@Nevay Nevay deleted the feature/span-exporter-result branch April 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change SpanExporter::export() result to Success or Failure
2 participants