-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade otel/build-protobuf image 0.2.1->0.11.0 #46
Upgrade otel/build-protobuf image 0.2.1->0.11.0 #46
Conversation
Upgrades `github.com/grpc-ecosystem/grpc-gateway` v1.16.0 -> v2.10.0 Upgrades `google.golang.org/protobuf` v1.27.1 -> v1.28.0 Switch from `github.com/golang/protobuf` to `google.golang.org/protobuf` entirely.
Looking at options to address Go 1.17 min requirement. Might be worth following suit for the repo. |
Can we use |
It doesn't look like there is a release that supports that version. go: creating new go.mod: module go.opentelemetry.io/proto/otlp
go: to add module requirements and sums:
go mod tidy
go: module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead.
go: added github.com/golang/protobuf v1.5.2
go: added github.com/grpc-ecosystem/grpc-gateway v1.16.0
go: added google.golang.org/grpc v1.45.0
go: added google.golang.org/protobuf v1.28.0 and go: creating new go.mod: module go.opentelemetry.io/proto/otlp
go: to add module requirements and sums:
go mod tidy
go: added github.com/grpc-ecosystem/grpc-gateway/v2 v2.10.0
go: added google.golang.org/grpc v1.45.0
go: added google.golang.org/protobuf v1.28.0 |
Given there is a security issue this is resolving, it seems to motivate moving forward to Go 1.17 early. |
@Aneurysm9 PTAL. I think I've figured out a way to upgrade reliably to where we want |
Fix #45
github.com/grpc-ecosystem/grpc-gateway
v1.16.0 -> v2.7.0 (last version that supports Go 1.14 and resolves vulnerability)github.com/golang/protobuf
togoogle.golang.org/protobuf
entirely.