Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #16

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

breedx-splk
Copy link
Contributor

Downstream projects are getting hit with protobuf updates that can't be merged. Hoping this might help.

grpc 1.56.1 -> 1.65.1
protobuf 3.23.4 -> 4.27.2

also bumped a couple of github actions.

@breedx-splk breedx-splk requested a review from a team July 24, 2024 16:43
@jack-berg
Copy link
Member

Ran the build locally to confirm this works. Unfortunately, we don't have project tooling at the moment to do a patch release. The release build accepts a released version of opentelemetry-proto as an input, builds against it, and releases with the same version. If we merge this and try to re-run the release build with 1.3.2 we'll get an error.

We can either:

  • Wait for the next opentelemetry-proto release
  • Update the project tooling to be able to sometimes append a suffix to the release version string to represent a patch

@trask
Copy link
Member

trask commented Jul 24, 2024

seems ok to wait (btw thx @breedx-splk for this, I wasn't clear what we needed to do to unblock those dependency updates)

@breedx-splk
Copy link
Contributor Author

@jack-berg I'm fine waiting for the next release of opentelemetry-proto, I think that's fine. Judging by the release history over there, it seems like a July version should happen shortly anyway. If the release builds are triggered manually we can merge this tho right?

@breedx-splk
Copy link
Contributor Author

seems ok to wait (btw thx @breedx-splk for this, I wasn't clear what we needed to do to unblock those dependency updates)

There may still be more, but this is probably part of it.

@jack-berg
Copy link
Member

If the release builds are triggered manually we can merge this tho right?

Yes.

@jack-berg jack-berg merged commit 7eed9d3 into open-telemetry:main Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants