Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to Go packages #360

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

tigrannajaryan
Copy link
Member

The go pacakges now correctly point to https://github.com/open-telemetry/opentelemetry-proto-go
repository where we have the generated files for Go.

Resolves #353

The go pacakges now correctly point to https://github.com/open-telemetry/opentelemetry-proto-go
repository where we have the generated files for Go.

Resolves open-telemetry#353
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break our gen-go test in this repo?

@tigrannajaryan
Copy link
Member Author

Does this break our gen-go test in this repo?

Doesn't seem so, the build passed.

@bogdandrutu bogdandrutu merged commit 0e254b5 into open-telemetry:main Feb 9, 2022
@tigrannajaryan tigrannajaryan deleted the rename-go-packages branch March 3, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go proto import paths do not match actual import paths
5 participants