Define csharp_namespace option #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
approved these changes
Jun 1, 2022
Kielek
approved these changes
Jun 1, 2022
arminru
approved these changes
Jun 1, 2022
|
Is this a breaking change for existing C# code? The existing code will no longer compile, right? Just want to confirm we are OK with this. Formally we are allowed to do this, since the code is explicitly excluded from our stability guarantees. |
From the standpoint of the .NET SDK, we will be ok making this change as we do not expose any of the generated code to end users. However, this will also be a breaking change for any end users that are generating code directly from these protos. Personally, I suspect the impact will be low. We should be ok citing that the protos have not reached 1.0 yet. |
SergeyKanzhelev
approved these changes
Jun 3, 2022
bogdandrutu
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes generated C# namespaces to have the prefix
OpenTelemetryinstead ofOpentelemetry