-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to indicate partial success in an OTLP export response [2] #414
Merged
jmacd
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:otlp-partial-success-rejected-semantics
Aug 3, 2022
Merged
Make it possible to indicate partial success in an OTLP export response [2] #414
jmacd
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:otlp-partial-success-rejected-semantics
Aug 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
reviewed
Jul 25, 2022
jmacd
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
jack-berg
approved these changes
Jul 26, 2022
tigrannajaryan
approved these changes
Jul 26, 2022
jmacd
reviewed
Jul 26, 2022
arminru
approved these changes
Aug 2, 2022
bogdandrutu
reviewed
Aug 2, 2022
arminru
approved these changes
Aug 3, 2022
bogdandrutu
added a commit
that referenced
this pull request
Aug 3, 2022
…#419) * Use buf to detect for wire breaking changes (#415) * Make it possible to indicate partial success in an OTLP export response [2] (#414) * Make it possible to indicate partial success in an OTLP export response * Update changelog with PR number * PR suggestions * Improve docs around using rejected as 0 to convey warnings * Adapt comments to match recent spec wording changes * Clarify behavior of partial success not set/empty Co-authored-by: Aaron Abbott <aaronabbott@google.com> Co-authored-by: Joao Grassi <joao@joaograssi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt in solving/addressing open-telemetry/opentelemetry-specification#2454. This uses the
rejected
semantics instead ofaccepted
as discussed in the initial PR #390.Related spec PR: open-telemetry/opentelemetry-specification#2696
The need for this new PR was that with
accepted
we were running into problems with the0
value being the same as the default/not set, plus general intention to avoid havingoptional
on the fields.I did some tests with sample apps to confirm the cases for backwards compatibility. Those can be checked in: joaopgrassi/otlp-partial-success-experimental. The TL;DR: Since it's a new field no breaking change is introduced. New sender will always have to check if the
partial_success
is set because they can be working with servers using the old protos.Some context on why this feature is desired:
This feature IS intended to help in the following scenarios:
400 - BadRequest
(status quo today)otlp.exporter.rejected.data_points=x
)This feature IS NOT intended to help in the following scenarios:
cc @tigrannajaryan @jmacd @jsuereth @jack-berg @reyang