Fix failing urllib test case

This test case started failing after a fix for the handling of empty metric collection cycles was added to the core repo. Fixes #2032
open-telemetry · Nov 2, 2023 · 90d79ae · 90d79ae
1 parent 657d502
commit 90d79ae
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -6,7 +6,7 @@ on:
     - 'release/*'
   pull_request:
 env:
-  CORE_REPO_SHA: 0ef76a5cc39626f783416ca75e43556e2bb2739d
+  CORE_REPO_SHA: d054dff47d2da663a39b9656d106c3d15f344269
 
 jobs:
   build:

diff --git a/instrumentation/opentelemetry-instrumentation-urllib/tests/test_metrics_instrumentation.py b/instrumentation/opentelemetry-instrumentation-urllib/tests/test_metrics_instrumentation.py
@@ -190,11 +190,18 @@ def test_metric_uninstrument(self):
             metrics = self.get_sorted_metrics()
             self.assertEqual(len(metrics), 3)
 
+            self.assertEqual(
+                metrics[0].data.data_points[0].sum, 1
+            )
+            self.assertEqual(
+                metrics[1].data.data_points[0].sum, 0
+            )
+            self.assertEqual(
+                metrics[2].data.data_points[0].sum, 6
+            )
+
             URLLibInstrumentor().uninstrument()
             with request.urlopen(self.URL):
-                metrics = self.get_sorted_metrics()
-                self.assertEqual(len(metrics), 3)
-
-                for metric in metrics:
-                    for point in list(metric.data.data_points):
-                        self.assertEqual(point.count, 1)
+                self.assertIsNone(
+                    self.memory_metrics_reader.get_metrics_data()
+                )