Fix lint

open-telemetry · Jul 26, 2022 · f4261ba · f4261ba
1 parent 1484ef0
commit f4261ba
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/...entelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py b/...entelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
@@ -217,18 +217,23 @@ def instrumented_urlopen(wrapped, instance, args, kwargs):
                 SpanAttributes.HTTP_SCHEME: instance.scheme,
                 SpanAttributes.HTTP_STATUS_CODE: response.status,
                 SpanAttributes.NET_PEER_NAME: instance.host,
-                SpanAttributes.NET_PEER_PORT: instance.port
+                SpanAttributes.NET_PEER_PORT: instance.port,
             }
 
             version = getattr(response, "version")
             if version:
-                metric_labels[SpanAttributes.HTTP_FLAVOR] = \
+                metric_labels[SpanAttributes.HTTP_FLAVOR] = (
                     "1.1" if version == 11 else "1.0"
+                )
 
             request_size = 0 if body is None else len(body)
             duration_histogram.record(elapsed_time, attributes=metric_labels)
-            request_size_histogram.record(request_size, attributes=metric_labels)
-            response_size_histogram.record(len(response.data), attributes=metric_labels)
+            request_size_histogram.record(
+                request_size, attributes=metric_labels
+            )
+            response_size_histogram.record(
+                len(response.data), attributes=metric_labels
+            )
 
             return response
 

diff --git a/instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_ip_support.py b/instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_ip_support.py
@@ -72,7 +72,9 @@ def assert_span(self, num_spans=1):
             return span_list[0]
         return span_list
 
-    def assert_success_span(self, response: urllib3.response.HTTPResponse, url: str):
+    def assert_success_span(
+        self, response: urllib3.response.HTTPResponse, url: str
+    ):
         self.assertEqual(b"Hello!", response.data)
 
         span = self.assert_span()
@@ -145,7 +147,8 @@ def test_basic_metric_check_client_size_get(self):
                                 )
                             self.assertIn(metric.name, expected_metrics)
                             self.assertDictEqual(
-                                expected_attributes, dict(data_point.attributes)
+                                expected_attributes,
+                                dict(data_point.attributes),
                             )
                             self.assertEqual(data_point.count, 1)
 
@@ -199,6 +202,7 @@ def test_basic_metric_check_client_size_post(self):
                             self.assertIn(metric.name, expected_metrics)
 
                             self.assertDictEqual(
-                                expected_attributes, dict(data_point.attributes)
+                                expected_attributes,
+                                dict(data_point.attributes),
                             )
                             self.assertEqual(data_point.count, 1)