Skip to content

Commit

Permalink
updated changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
galbash committed Apr 8, 2024
1 parent 4e6bb75 commit f9ee608
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased
### Added

- `opentelemetry-instrumentation-pika` Instrumentation for `channel.consume()` function
([#2397](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2397)))

### Breaking changes

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -268,5 +268,5 @@ def popleft(self, *args, **kwargs):
self._self_active_span.end()
except Exception as inst_exception: # pylint: disable=W0703
_LOG.exception(inst_exception)
finally:
return evt

return evt
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,15 @@ def test_instrument_api(self) -> None:
@mock.patch(
"opentelemetry.instrumentation.pika.PikaInstrumentor._instrument_blocking_channel_consumers"
)
@mock.patch(
"opentelemetry.instrumentation.pika.PikaInstrumentor._decorate_queue_consumer_generator"
)
def test_instrument(
self,
instrument_blocking_channel_consumers: mock.MagicMock,
instrument_basic_consume: mock.MagicMock,
instrument_channel_functions: mock.MagicMock,
instrument_queue_consumer_generator: mock.MagicMock,
):
PikaInstrumentor.instrument_channel(channel=self.channel)
assert hasattr(
Expand All @@ -70,6 +74,7 @@ def test_instrument(
instrument_blocking_channel_consumers.assert_called_once()
instrument_basic_consume.assert_called_once()
instrument_channel_functions.assert_called_once()
instrument_queue_consumer_generator.assert_called_once()

@mock.patch("opentelemetry.instrumentation.pika.utils._decorate_callback")
def test_instrument_consumers(
Expand Down

0 comments on commit f9ee608

Please sign in to comment.