Error in urllib3 instrumentation example in instrumentation documentation

[JM-ET]

Describe your environment
https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/urllib3/urllib3.html
section: Request/Response hooks
Contains an error in example which causes pylint
no-value-for-parameter (self)

Steps to reproduce
Current example on this page:
URLLib3Instrumentor.instrument(
request_hook=request_hook, response_hook=response_hook)
)

What is the expected behaviour?
Works and runs successfully

What is the actual behaviour?
pylint - no-value-for-parameter (self)
And fails to run if disable lint check

Correction
Need to create an instance of URLLib3Instrumentor - missing () after class name

URLLib3Instrumentor().instrument(
request_hook=request_hook, response_hook=response_hook)
)

example under section: Usage is correct, just not this example.

[srikanthccv]

Thanks for the report. Feel free to send a pull request.

[yashaswi2000]

can i pick this issue up, if this is not already being worked on. thanks!

[JM-ET]

Hello. Sure; I can/could not determine the minimum acceptable level of validation/testing required to accompany the change in a PR; admittedly a very small change. Kind regards John

…

On Tue, 9 May 2023 at 12:28, yashaswi2000 ***@***.***> wrote: can i pick this issue up, if this is not already being worked on. thanks! — Reply to this email directly, view it on GitHub <#1767 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOEXKYCBXICDBUHCPIYTXNLXFIS7BANCNFSM6AAAAAAXFOHR4A> . You are receiving this because you authored the thread.Message ID: ***@***.*** .com>