make span attribute available to urllib #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
reviewed
Mar 21, 2022
CHANGELOG.md
Outdated
| @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Added | |||
|
|
|||
| - `opentelemetry-instrumentation-urllib` make spam attribute available to urllib | |||
There was a problem hiding this comment.
Suggested change
| - `opentelemetry-instrumentation-urllib` make spam attribute available to urllib | |
| - `opentelemetry-instrumentation-urllib` make span attributes available to sampler |
lzchen
reviewed
Mar 21, 2022
| @@ -183,15 +183,17 @@ def _instrumented_open_call( | |||
| SpanAttributes.HTTP_URL: url, | |||
| } | |||
|
|
|||
| span_attributes = { | |||
There was a problem hiding this comment.
There is already a dict with the exact same fields called labels right above. Maybe we can just use that.
There was a problem hiding this comment.
removed it , I thought we needed a new dict for span attributes
lzchen
approved these changes
Mar 21, 2022
ocelotl
suggested changes
Mar 21, 2022
...on/opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/__init__.py
Show resolved
Hide resolved
ocelotl
approved these changes
Apr 11, 2022
srikanthccv
approved these changes
Apr 12, 2022
|
@DiptoChakrabarty Please resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #938
Type of change
Makes use of span attribute in the urllib instrumentation
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.