Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support confluent kafka #1111

Merged
merged 8 commits into from
Jun 3, 2022
Merged

Support confluent kafka #1111

merged 8 commits into from
Jun 3, 2022

Conversation

oxeye-dorkolog
Copy link
Contributor

Description

This PR impelements instrumentation for confluent-kafka client. it heavily relies on PR-905. It creates proxy objects for cimpi.Producer and cimpl.Consumer and patch their methods using wrapt

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Deployed confluent-kafka producer/consumer with manual and auto instrumentation

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@oxeye-dorkolog oxeye-dorkolog requested a review from a team May 31, 2022 12:12
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 31, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@oxeye-dorkolog oxeye-dorkolog force-pushed the support-confluent-kafka branch from dd5343a to 442db3a Compare June 2, 2022 07:53
@ocelotl ocelotl merged commit a8b9829 into open-telemetry:main Jun 3, 2022
@Sahadar
Copy link

Sahadar commented Jun 18, 2022

Hello,
Please don't forget to place it in PyPI - currently its still not available to install:
https://pypi.org/search/?q=opentelemetry-instrumentation-confluent-kafka&o=

@srikanthccv
Copy link
Member

srikanthccv commented Jun 21, 2022 •
edited
Loading

@Sahadar We didn't forget. It's just not released yet. It should be available on pypi from next monthly release.

@srikanthccv srikanthccv mentioned this pull request Jun 21, 2022
Closed
6 tasks
@lzchen
Copy link
Contributor

lzchen commented Jun 22, 2022

@oxeye-dorkolog
Please add yourself to component owners for this package.

@oxeye-dorkolog
Copy link
Contributor Author

@lzchen already did as part of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxeye-nikolay oxeye-nikolay oxeye-nikolay approved these changes

Assignees

@oxeye-dorkolog oxeye-dorkolog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oxeye-dorkolog @Sahadar @srikanthccv @lzchen @oxeye-nikolay @ocelotl