Add support for regular expression matching and sanitizing of headers. #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@rogersd |
|
@rogersd that's a lot of changes in lot of files. Please open a small and separate PR for each change to get reviews. It's not possible to review this PR as is. |
|
Yeah, I'm going to, I just need to wait for the company I work for to get set up with EasyCLA. In the meantime I'll convert this to a draft PR. |
Also: Add test cases for regular expression matching. Add test cases for "all" keyword. Add test cases for header sanitizing. Add documentation for regular expression matching and header sanitation. Various documentation cleanups and standardization. Fix keys() in class ASGIGetter so it returns the HTTP header keys instead of a list of available request data. This makes it consistent with the WSGIGetter keys() method. Make ASGIGetter.get() compare all keys in a case insensitive manner. Use resp.text instead of resp.body for Falcon 3 to avoid a deprecation warning. Remove duplicate documentation from instrumentation/opentelemetry-instrumentation-flask/README.rst as in ae7a415 Various formatting fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for regular expression matching and sanitizing of headers.
Add test cases for regular expression matching.
Add test cases for "all" keyword.
Add test cases for header sanitizing.
Add documentation for regular expression matching and header sanitation.
Various documentation cleanups and standardization.
Fix keys() in class ASGIGetter so it returns the HTTP header keys instead of a list of available request data. This makes it consistent with the WSGIGetter keys() method.
Make ASGIGetter.get() compare all keys in a case insensitive manner.
Use resp.text instead of resp.body for Falcon 3 to avoid a deprecation warning.
Remove duplicate documentation from instrumentation/opentelemetry-instrumentation-flask/README.rst as in ae7a415
Various formatting fixes.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have run the existing unit tests, and also added new ones for the new features.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.