updated to remove directions from existing metrics. tests updated to … #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…e_from_system_metrics
|
Please run build at earliest convenience. Thanks |
…e_from_system_metrics
…em_metrics' of https://github.com/fidelity/opentelemetry-python-contrib into feature/issue_1171_remove_direction_attribute_from_system_metrics
…e_from_system_metrics
|
venv linting doesnt show any issues now. Should be good to go |
lzchen
reviewed
Aug 30, 2022
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Aug 30, 2022
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Aug 30, 2022
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Show resolved
Hide resolved
lzchen
approved these changes
Aug 30, 2022
…e_from_system_metrics
…e_from_system_metrics
…e_from_system_metrics
|
@lzchen I am not able to merge this. Once this passes the checks again, could you please merge this for me? |
|
Thanks for the help! |
|
I believe this should be reverted open-telemetry/opentelemetry-specification@f0c001e |
|
@srikanthccv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…match
Description
Updated metrics to match the approved spec. Directions attribute moved out to be individual metrics.
Fixes # (issue)
#1171
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.