-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install of Python 3.10 on GitHub Actions #1609
Conversation
In PR open-telemetry#1604 the Python version was upgraded to Python 3.10 to fix a local issue on M1 MacBooks. The GitHub Action workflows now exit with the following message for the docker-tests, spellcheck and lint checks, skipping these checks. ``` lint create: /home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/.tox/lint SKIPPED: InterpreterNotFound: python3.10 ___________________________________ summary ____________________________________ SKIPPED: lint: InterpreterNotFound: python3.10 congratulations :) ``` Upgrade the Python version in the GitHub Actions workflow to fix this.
@ocelotl This seems important to fix the CI build :) |
My bad. In YAML |
3fc8502
to
7f5df46
Compare
Please retry the build :) Should work now 🤞 |
Upgrade the asyncpg and psycopg2 packages, they don't work on Python 3.10. This also fixes running these tests no M1 MacBooks.
Upgraded the dependencies that won't install on Python 3.10. Please retry the build again 😬 Note to self: Don't multi task multiple fixes. I had them already upgraded for another PR I wanted to make, to fix the local build on M1 MacBooks, but turns out it's needed for this PR as well. |
The changelog check failure is not something I can do anything about, I think? Does it need the "skip changelog" label? |
Please fix the lint |
They went unnoticed while the CI didn't fail on the lint task not working.
I've fixed the issues that were merged into main. Let's merge this before more issues get merged into main. I ignored a couple issue flagged pylint because fixing those would actually mean changing the implementation of those methods. You can find them by looking for the |
@srikanthccv the build passed! 🎉 |
Thanks @tombruijn |
Thanks for all the help @srikanthccv ! |
Description
In PR #1604 the Python version was upgraded to Python 3.10 to fix a local issue on M1 MacBooks.
The GitHub Action workflows now exit with the following message for the docker-tests, spellcheck and lint checks, skipping these checks.
Upgrade the Python version in the GitHub Actions workflow to fix this.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist: