Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong package/project name for opentelemetry-resource-detector-azure #1942

Closed

Conversation

musicinmybrain
Copy link
Contributor

Description

This fixes package/project name for opentelemetry-resource-detector-azure. It looks like the pyproject.toml was copied from opentelemetry-resource-detector-container without updating the project name.

Fixes # (issue)

(No issue filed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

By inspection only.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added N/A
  • Documentation has been updated N/A

@musicinmybrain musicinmybrain requested a review from a team September 8, 2023 13:48
@ocelotl
Copy link
Contributor

ocelotl commented Sep 29, 2023

Thanks for the PR, @musicinmybrain, #1950 got merged first, closing this PR. ✌️

@ocelotl ocelotl closed this Sep 29, 2023
@musicinmybrain
Copy link
Contributor Author

Thanks for the PR, @musicinmybrain, #1950 got merged first, closing this PR. ✌️

Works for me! Thanks for taking care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants