Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for __name__ before tracing a coro #2353

Closed
wants to merge 3 commits into from

Conversation

fnmut
Copy link

@fnmut fnmut commented Mar 19, 2024

Description

Asyncio send function does not have a name. This checks for name before tracing.

Fixes #2340

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Used the repro case in issue #2340

I am also running tests locally but they are taking a long time...

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Mar 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: fnmut / name: Christian Burke (7d693fc, 6dc1ff1)
  • ✅ login: ocelotl / name: Diego Hurtado (e8fb8b1)

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add a test. BTW to reduce the number of tests to run locally you can run a specific tox environment instead of all, e.g. tox -e py311-test-instrumentation-asyncio if you python 3.11.

Also please add an entry in the CHANGELOG.md under Unreleased > Fixed

@fnmut fnmut closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'async_generator_asend' object has no attribute '__name__'
3 participants