-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new HTTP semantic convention opt-in for Falcon #2790
Implement new HTTP semantic convention opt-in for Falcon #2790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A big thanks for working on this one. Just some comments
instrumentation/opentelemetry-instrumentation-falcon/tests/test_falcon.py
Outdated
Show resolved
Hide resolved
...on/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
Outdated
Show resolved
Hide resolved
@FilipNikolovski |
Thanks for the feedback. I've updated the file, but that step is still failing 🤷. Not sure if I need to run |
You need to run it locally and commit the updated files so it will match on CI |
...on/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
Outdated
Show resolved
Hide resolved
...on/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
Outdated
Show resolved
Hide resolved
...on/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
Show resolved
Hide resolved
…ndependent from tracing decisions; update tests
@xrmx running
|
...on/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
Outdated
Show resolved
Hide resolved
…ry-python-contrib into falcon_new_semconv
Description
This change updates the falcon instrumentor to adhere to the new HTTP semantic conventions, according to the migration plan outlined here:
also fixes #1532
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated the tests to assert that the new span and duration attributes have been added.