add python 3.9 tests #466
Merged
add python 3.9 tests #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
srikanthccv,
a team and
lzchen
and removed request for
a team
srikanthccv
approved these changes
Apr 24, 2021
lzchen
reviewed
Apr 27, 2021
tox.ini
Outdated
| @@ -6,146 +6,146 @@ envlist = | |||
| ; for specifying supported Python versions per package. | |||
|
|
|||
There was a problem hiding this comment.
Please rebase so you can add instrumentation-base :D
lzchen
approved these changes
Apr 27, 2021
@lonewolf3739 turns out the problem was that we pinned the version of Sphinx to an old version that contained a bug w/ python 3.9. fixed this by unpinning sphinx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9 wasn't being tested in this repo, fixing that.