Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scikit-learn version #518

Closed
wants to merge 1 commit into from
Closed

Update scikit-learn version #518

wants to merge 1 commit into from

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented May 26, 2021

Fixes #517

This should fix the lint failure of #515

@ocelotl ocelotl requested a review from codeboten May 26, 2021 23:01
@ocelotl ocelotl self-assigned this May 26, 2021
@ocelotl ocelotl requested review from a team and lzchen and removed request for a team May 26, 2021 23:01
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 26, 2021
@codeboten
Copy link
Contributor

Does this need a changelog since we're updating the dependency here? @ocelotl

@codeboten
Copy link
Contributor

@ocelotl please resolve the conflict and we can get this merged.

@ocelotl
Copy link
Contributor Author

ocelotl commented May 27, 2021

I think this is now not needed now that #475 has been merged, closing.

@ocelotl ocelotl closed this May 27, 2021
@ocelotl ocelotl deleted the issue_517 branch May 27, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sklearn version
3 participants
@ocelotl @codeboten @lzchen