Require aiopg to be less than 1.3.0 #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanSiu1995
requested review from
a team,
owais and
aabmass
and removed request for
a team
owais
reviewed
Jul 1, 2021
| @@ -13,4 +13,4 @@ | |||
| # limitations under the License. | |||
|
|
|||
|
|
|||
| _instruments = ("aiopg >= 0.13.0",) | |||
| _instruments = ("aiopg <= 1.2.1",) | |||
There was a problem hiding this comment.
shouldn't this be >=0.13.0, <1.3.0 consider 1.3 introduced the breaking change and for some reason we did not want to support versions older than 0.13?
There was a problem hiding this comment.
I wasn't aware of the support of multiple conditions in python.
I have updated accordingly.
There was a problem hiding this comment.
Thanks. Can you please open an issue that tracks adding support for 1.3.0 and newer versions? Please also include details about the issue this instrumentation has today.
There was a problem hiding this comment.
Created as #561
codeboten
approved these changes
Jul 1, 2021
owais
approved these changes
Jul 1, 2021
|
For more context, breaking change introduced here: https://github.com/aio-libs/aiopg/pull/813/files |
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 1, 2021
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aiopg latest version has breaking changes in its internal object.
It breaks the build in default branch.
I have fixed the version here to make the build pass first.
It has a break changes in its API so we may need a further discussion on how to handle this case.
Fixes # (issue)
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: