New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IdsGenerator interface to SDK #1493

Closed

codeboten opened this issue Dec 17, 2020 · 0 comments · Fixed by #1514

Assignees

Labels

api good first issue help wanted

Contributor

codeboten commented Dec 17, 2020

The spec identifies the IdsGenerator interface as belonging to the SDK, this needs to be moved out of the API before 1.0. This will require an update to the contrib repo: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/master/sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/aws_xray_ids_generator.py

codeboten added api 1.0.0rc1 labels

codeboten added help wanted good first issue labels

lzchen self-assigned this

lzchen mentioned this issue

Move idsgenerator from api into sdk package #1514

Merged

lzchen closed this as completed in #1514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment