Move idsgenerator from api into sdk package #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
requested review from
a team,
owais and
aabmass
and removed request for
a team
codeboten
approved these changes
Jan 9, 2021
toumorokoshi
approved these changes
Jan 11, 2021
| @@ -10,7 +10,7 @@ env: | |||
| # Otherwise, set variable to the commit of your branch on | |||
| # opentelemetry-python-contrib which is compatible with these Core repo | |||
| # changes. | |||
| CONTRIB_REPO_SHA: master | |||
There was a problem hiding this comment.
I presume this needs to be switched back in lockstep with the opentelemetry-contrib changes?
There was a problem hiding this comment.
Don't think so. The builds will keep passing until a new change that affects both repos needs to be made.
owais
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1493