Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Consider removing Tracer.create_span() #152

Closed
carlosalberto opened this issue Sep 19, 2019 · 3 comments · Fixed by #290
Closed

API: Consider removing Tracer.create_span() #152

carlosalberto opened this issue Sep 19, 2019 · 3 comments · Fixed by #290
Assignees
@codeboten
Labels
api Affects the API package. discussion Issue or PR that needs/is extended discussion. tracing
Milestone
Alpha v0.3

Comments

@carlosalberto
Copy link
Contributor

Have been reviewing other languages' implementations and it seems there's no way to create non-started Spans.

My take would be on removing the Tracer.create_span() method (at least from the API), to reduce API surface. It also feels like one of the cases where it makes sense to put it back in the API if/when we have a real need for it.

However, I remember the OC crew mentioning why it was needed in Python. Anybody would like to chime in?
@Oberon00 Oberon00 added api Affects the API package. tracing labels Sep 24, 2019
@Oberon00
Copy link
Member

See also #97 (comment)

@c24t c24t added this to the Alpha v0.2 milestone Oct 11, 2019
@c24t c24t added the discussion Issue or PR that needs/is extended discussion. label Oct 31, 2019
@c24t c24t modified the milestones: Alpha v0.2, Alpha v0.3 Oct 31, 2019
@codeboten
Copy link
Contributor

Is the plan to go ahead and remove create_span from the API?

@carlosalberto
Copy link
Contributor Author

@codeboten Yeah, as far as I remember, while keeping it in the SDK ;)

@codeboten codeboten mentioned this issue Nov 14, 2019
Merged
@codeboten codeboten self-assigned this Nov 14, 2019
@codeboten codeboten mentioned this issue Nov 14, 2019
Merged
@c24t c24t closed this as completed in #290 Nov 25, 2019
c24t pushed a commit that referenced this issue Nov 25, 2019
@c24t
Remove create_span from the API (#290)
033bcdc 
Simplify the API by removing create_span.

Resolves #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
api Affects the API package. discussion Issue or PR that needs/is extended discussion. tracing
Projects
None yet
Milestone
Alpha v0.3
Development

Successfully merging a pull request may close this issue.

Removing create_span from the api codeboten/opentelemetry-python
4 participants
@codeboten @carlosalberto @Oberon00 @c24t