Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement inject() and extract() methods on the OT shim #243

Closed
johananl opened this issue Oct 25, 2019 · 2 comments
Closed

Implement inject() and extract() methods on the OT shim #243

johananl opened this issue Oct 25, 2019 · 2 comments
Labels
shim OpenTracing or OpenCensus compatibility tracing
Milestone

Comments

@johananl
Copy link
Contributor

We should implement the inject() and extract() methods on the OT shim's TracerShim class to allow inter-process context propagation:

def inject(self, span_context, format, carrier):
# pylint: disable=redefined-builtin
logger.warning(
"Calling unimplemented method inject() on class %s",
self.__class__.__name__,
)
# TODO: Implement.
def extract(self, format, carrier):
# pylint: disable=redefined-builtin
logger.warning(
"Calling unimplemented method extract() on class %s",
self.__class__.__name__,
)
# TODO: Implement.

@Oberon00 Oberon00 added shim OpenTracing or OpenCensus compatibility tracing labels Oct 28, 2019
@mauriciovasquezbernal
Copy link
Member

mauriciovasquezbernal commented Oct 30, 2019

I am giving it a try, so you could assign it to me.

@johananl
Copy link
Contributor Author

Closed in #256.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shim OpenTracing or OpenCensus compatibility tracing
Projects
None yet
Development

No branches or pull requests

4 participants