Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set max number of commits in performance graph #1498

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Set max number of commits in performance graph #1498

merged 1 commit into from
Dec 22, 2020

Conversation

NathanielRN
Copy link
Contributor

@NathanielRN NathanielRN commented Dec 21, 2020 •
edited
Loading

Description

As a follow up to #1443, this PR adds a limit to the number of commits saved and displayed in the performance graph.

By default there is no limit so I thought this would be a good preemptative measure to avoid a noisy (and maybe unreadable?) graph.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

N/A

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
    - [ ] Changelogs have been updated
    - [ ] Unit tests have been added
    - [ ] Documentation has been updated

@NathanielRN NathanielRN requested review from a team, toumorokoshi and hectorhdzg and removed request for a team December 21, 2020 17:50
codeboten
codeboten reviewed Dec 21, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the issue/pr in the description is incorrect

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 21, 2020
@NathanielRN
Copy link
Contributor Author

@codeboten Thanks! That was the Contrib PR... I’ve updated it!

codeboten
codeboten approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeboten codeboten merged commit dbe9d38 into open-telemetry:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@aabmass aabmass aabmass approved these changes

@codeboten codeboten codeboten approved these changes

@toumorokoshi toumorokoshi Awaiting requested review from toumorokoshi

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NathanielRN @codeboten @aabmass @ocelotl