Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch unit tests from unittest.mock to SDK & in-memory exporter #303

Closed
Oberon00 opened this issue Nov 25, 2019 · 2 comments · Fixed by #306
Closed

Switch unit tests from unittest.mock to SDK & in-memory exporter #303

Oberon00 opened this issue Nov 25, 2019 · 2 comments · Fixed by #306
Assignees
@codeboten
Labels
tests tracing

Comments

@Oberon00
Copy link
Member

See #290 (comment).
Currently tests are cumbersome to write and actually we probably don't want to test which API calls are made but what Spans would result in most cases. For this a SDK with in-memory exporter would be better than using unittest.mock.
@Oberon00 Oberon00 mentioned this issue Nov 25, 2019
Merged
@codeboten codeboten self-assigned this Nov 26, 2019
@codeboten codeboten mentioned this issue Nov 26, 2019
Merged
@mauriciovasquezbernal
Copy link
Member

I don't think this is actually done. #306 fixed that for wsgi and Flask, but there are other cases where mock is used:

opentelemetry-python/ext/opentelemetry-ext-http-requests/tests/test_requests_integration.py

Line 34 in c8b336d

self.get_tracer_patcher = mock.patch.object(

opentelemetry-python/ext/opentelemetry-ext-dbapi/tests/test_dbapi_integration.py

Line 26 in c8b336d

self.start_current_span_patcher = mock.patch.object(

opentelemetry-python/ext/opentelemetry-ext-mysql/tests/test_mysql_integration.py

Line 28 in c8b336d

start_current_span_patcher = mock.patch.object(

Merged
Merged
c24t added a commit that referenced this issue Apr 20, 2020
@mauriciovasquezbernal @toumorokoshi @c24t
ext: Use TestBase (#586)
4115c1b 
Update tests to use TestBase as described on #303.

Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Co-authored-by: Chris Kleinknecht <libc@google.com>
@mauriciovasquezbernal
Copy link
Member

I think it's solved now by the above PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
tests tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using InMemorySpanExporter for wsgi/flask tests codeboten/opentelemetry-python
3 participants
@codeboten @Oberon00 @mauriciovasquezbernal