Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blacklisting for wsgi apps #565

Closed
lzchen opened this issue Apr 9, 2020 · 3 comments
Closed

Add blacklisting for wsgi apps #565

lzchen opened this issue Apr 9, 2020 · 3 comments
Assignees
Labels
instrumentation Related to the instrumentation of third party libraries or frameworks tracing

Comments

@lzchen
Copy link
Contributor

lzchen commented Apr 9, 2020

Just like in Opencensus, users should be able to configure paths and hosts that they do not want to be traced.

Auto-instrumented apps would probably not have blacklisted paths/hosts.

@codeboten
Copy link
Contributor

This would be super useful. Would like to see it renamed excluded list or filtered list.

@lzchen
Copy link
Contributor Author

lzchen commented Apr 9, 2020

Currently, there are two ways of instrumenting a Flask application, through wsgi OpenTelemetryMiddleware and ext-flask FlaskInstrumenter. I believe the latter is intended to be just used for auto-instrumentation. We should have only one way of recommending users to instrument their Flask apps (manual). I believe @ocelotl is taking a look at this and whether we can leverage some of the existing wsgi logic for instruementation.

Until then, configuration for wsgi/flask apps is difficult to do, so might want to hold off on this until then.

@lzchen
Copy link
Contributor Author

lzchen commented Apr 9, 2020

Continuation of [#353]

@ocelotl ocelotl self-assigned this Apr 26, 2020
@lzchen lzchen assigned lzchen and unassigned ocelotl Apr 29, 2020
@ocelotl ocelotl added the instrumentation Related to the instrumentation of third party libraries or frameworks label Apr 30, 2020
@lzchen lzchen closed this as completed Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instrumentation Related to the instrumentation of third party libraries or frameworks tracing
Projects
None yet
Development

No branches or pull requests

3 participants