Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make suppress_instrumentation emit a defaultspan #581

Closed
toumorokoshi opened this issue Apr 14, 2020 · 2 comments
Closed

make suppress_instrumentation emit a defaultspan #581

toumorokoshi opened this issue Apr 14, 2020 · 2 comments
Labels

Comments

@toumorokoshi
Copy link
Member

Right now, multiple extensions are adding their own suppress_instrumentation code, to not emit span information.

It would be great if we could suppress_instrumentation on a global level, such as described in open-telemetry/opentelemetry-specification#530.

@c24t
Copy link
Member

c24t commented Apr 16, 2020

Related to #565

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
* feat: add OpenTracing example

* fix: review comments

- Combine `Tracer` and `.init` to one line
- Use `setTimeout` to be consistent with other example
- Remove unused dependency
- Add missing keywords
- Update README
- Add missing `"use strict";`

* fix: review comments

- Update README
- Separate shim to another file

* fix: remove unnecessary file
@github-actions
Copy link

This issue was marked stale due to lack of activity. It will be closed in 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants