Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox -e lint is failing in some cases #613

Closed
ocelotl opened this issue Apr 25, 2020 · 0 comments · Fixed by #614
Closed

tox -e lint is failing in some cases #613

ocelotl opened this issue Apr 25, 2020 · 0 comments · Fixed by #614
Assignees
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Apr 25, 2020

Apparently, this does not happen in CI, but I can reproduce with master in my computer. Running tox -e lint fails with this error:

lint create: /home/ocelotl/open-telemetry/opentelemetry-python/.tox/lint
lint installdeps: -cdev-requirements.txt, pylint, flake8, isort, black, psutil, readme_renderer, httpretty
lint installed: appdirs==1.4.3,astroid==2.3.3,attrs==19.3.0,black==19.10b0,bleach==3.1.4,click==7.1.1,docutils==0.16,entrypoints==0.3,flake8==3.7.9,httpretty==1.0.2,isort==4.3.21,lazy-object-proxy==1.4.3,mccabe==0.6.1,pathspec==0.8.0,psutil==5.7.0,pycodestyle==2.5.0,pyflakes==2.1.1,Pygments==2.6.1,pylint==2.4.4,readme-renderer==24.0,regex==2020.4.4,six==1.14.0,toml==0.10.0,typed-ast==1.4.1,webencodings==0.5.1,wrapt==1.11.2
lint run-test-pre: PYTHONHASHSEED='2658278386'
lint run-test-pre: commands[0] | python scripts/eachdist.py install --editable
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-api
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-sdk
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-auto-instrumentation
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-wsgi
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-psycopg2
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-zipkin
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-prometheus
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-opentracing-shim
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-mysql
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-grpc
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-otcollector
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-http-requests
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-flask
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-pymongo
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-jaeger
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-pymysql
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-dbapi
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/tests/util
Obtaining file:///home/ocelotl/open-telemetry/opentelemetry-python/docs/examples/opentelemetry-example-app
Collecting psycopg2-binary>=2.7.3.1
  Using cached psycopg2_binary-2.8.5-cp38-cp38-manylinux1_x86_64.whl (3.0 MB)
Requirement already satisfied: wrapt<2.0.0,>=1.0.0 in ./.tox/lint/lib/python3.8/site-packages (from opentelemetry-ext-psycopg2==0.7.dev0) (1.11.2)
Collecting requests~=2.7
  Using cached requests-2.23.0-py2.py3-none-any.whl (58 kB)
Processing /home/ocelotl/.cache/pip/wheels/a7/f7/eb/1abd6e61e5a9ecbc7d05a2a84c045b99cb30a0d3e760dab497/prometheus_client-0.7.1-py3-none-any.whl
Collecting Deprecated>=1.2.6
  Using cached Deprecated-1.2.9-py2.py3-none-any.whl (8.6 kB)
Processing /home/ocelotl/.cache/pip/wheels/d8/59/32/28a68fc65ba428fce889c46994767b2e4d000ee81e2ae47512/opentracing-2.3.0-py3-none-any.whl
ERROR: Could not find a version that satisfies the requirement opentelemetry-ext-dbapi==0.7.dev0 (from opentelemetry-ext-mysql==0.7.dev0) (from versions: 0.4a1, 0.5b0, 0.6b0)
ERROR: No matching distribution found for opentelemetry-ext-dbapi==0.7.dev0 (from opentelemetry-ext-mysql==0.7.dev0)
>>> python -m pip install -e file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-api -e file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-sdk -e file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-auto-instrumentation -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-wsgi -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-psycopg2 -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-zipkin -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-prometheus -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-opentracing-shim -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-mysql -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-grpc -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-otcollector -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-http-requests -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-flask -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-pymongo -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-jaeger -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-pymysql -e file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-dbapi -e file:///home/ocelotl/open-telemetry/opentelemetry-python/tests/util -e file:///home/ocelotl/open-telemetry/opentelemetry-python/docs/examples/opentelemetry-example-app
'python -m pip install -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-api' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-sdk' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/opentelemetry-auto-instrumentation' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-wsgi' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-psycopg2' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-zipkin' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-prometheus' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-opentracing-shim' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-mysql' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-grpc' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-otcollector' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-http-requests' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-flask' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-pymongo' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-jaeger' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-pymysql' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/ext/opentelemetry-ext-dbapi' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/tests/util' -e 'file:///home/ocelotl/open-telemetry/opentelemetry-python/docs/examples/opentelemetry-example-app' ' failed with code 1
ERROR: InvocationError for command /home/ocelotl/open-telemetry/opentelemetry-python/.tox/lint/bin/python scripts/eachdist.py install --editable (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   lint: commands failed

This change seems to fix the problem:

diff --git a/eachdist.ini b/eachdist.ini
index 59f212f7..b573b838 100644
--- a/eachdist.ini
+++ b/eachdist.ini
@@ -6,6 +6,7 @@ sortfirst=
     opentelemetry-sdk
     opentelemetry-auto-instrumentation
     ext/opentelemetry-ext-wsgi
+    ext/opentelemetry-ext-dbapi
     ext/*
 
 [lintroots]
@ocelotl ocelotl added the bug Something isn't working label Apr 25, 2020
@ocelotl ocelotl self-assigned this Apr 25, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 25, 2020
toumorokoshi pushed a commit that referenced this issue Apr 27, 2020
Fixes #613

some packages depend on the newest dev version of dbapi, which isn't published yet
when a package in a virtualenv is installed, it will attempt to install those dependencies, which searches on pypi

Installing the local package ensures that 0.7 is installed, so pip sees that and skips trying to resolve against pypi (when it won't find the version).
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
closes open-telemetry#612

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant