Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wsgi: set error status on span #846

Closed
majorgreys opened this issue Jun 22, 2020 · 0 comments · Fixed by #864
Closed

wsgi: set error status on span #846

majorgreys opened this issue Jun 22, 2020 · 0 comments · Fixed by #864
Labels
good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@majorgreys
Copy link
Contributor

The wsgi instrumentation does not set an error status if an exception is caught while handling a request:

https://github.com/open-telemetry/opentelemetry-python/blob/master/ext/opentelemetry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py#L212
@codeboten codeboten added good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks labels Jun 25, 2020
@jan25 jan25 mentioned this issue Jun 27, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mwear
SDK Resource (open-telemetry#846)
abd191b 
* feat: add Resource.empty() method

* feat: add resource to BasicTracerProvider and assign to Spans

* feat: add Resource.createLibraryResource method

* refactor: rename LIBARY_RESOURCE -> TELEMETRY_SDK_RESOURCE

* feat: add resource to ReadableSpan interface

* feat: add Resource to NodeTracerProvider

* feat: add Resource to WebTracerProvider

* refactor: move resource-assertions

* feat: add Resource to instruments

* refactor: add SDK_INFO to core; simplify SDK resource creation

* chore: docs and cleanup

* docs: no need to update the copyright

* chore: move resources to devDependencies where applicable

* refactor: add resource to TraceConfig

* refactor: add resource to MeterConfig

* refactor: change resource visibility on Meter

* refactor: move resource-assertions to test/util
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
export resource to exporters (open-telemetry#843)
4627892 
* export resource to exporters

* update Zipkin and Stackdriver exporter to use Resource

* chore: remove redundant dependency

* update Collector exporter to use Resource

* rebase with open-telemetry#846

* minor

* fix collector resource

* fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set span status on wsgi errors jan25/opentelemetry-python
2 participants
@majorgreys @codeboten