Fixed typo in boostrap command to install the correct package #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
fix-boostrap-command-package-name
branch
from
a51ac43
to
a2cdc0d
Compare
lzchen
approved these changes
Sep 21, 2020
codeboten
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Thanks for fixing this... It looks like the comment was marked as resolved in the original PR but the fix was missed here: #1039 (comment)
My bad. I think it was probably a bad rebase. |
alertedsnake
pushed a commit
to alertedsnake/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…-telemetry#1138) * feat(opentelemetry-js): infer zipkin service name from resource * Update packages/opentelemetry-exporter-zipkin/src/zipkin.ts making service name optional for zipkin exporter Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: making serviceName optional for zipkin config * fix: resolving type issues * Update packages/opentelemetry-exporter-zipkin/src/zipkin.ts making config object optional for zipkin Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * refactor: making default service name a constant Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> Co-authored-by: Mayur Kale <mayurkale@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bootstrap command had wrong library: instrumentation mapping. This commit fixes it.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: