Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make propagators a namespace #1591

Merged
merged 12 commits into from
Feb 16, 2021
Merged

Make propagators a namespace #1591

merged 12 commits into from
Feb 16, 2021

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Feb 9, 2021

Fixes #1590

Makes propagators a namespace so that we can have proper propagators in the contrib repo as well as here.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of opentelemetry-instrumentation/ have changed

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR: Add OpenTracing propagator opentelemetry-python-contrib#302

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 9, 2021
@ocelotl ocelotl requested review from a team, codeboten and aabmass and removed request for a team February 9, 2021 17:20
@ocelotl ocelotl requested a review from lzchen February 9, 2021 23:08
@ocelotl ocelotl force-pushed the issue_1590 branch 5 times, most recently from d151f56 to 4c7bbf7 Compare February 12, 2021 03:09
.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes here are ok. I'm curious though, it feels weird to have to import a util package for the only methods in propagators that we care about inject & extract

Any thoughts?

.github/workflows/test.yml Outdated Show resolved Hide resolved
@ocelotl
Copy link
Contributor Author

ocelotl commented Feb 16, 2021

I think the changes here are ok. I'm curious though, it feels weird to have to import a util package for the only methods in propagators that we care about inject & extract

Any thoughts?

@ocelotl ocelotl closed this Feb 16, 2021
@ocelotl ocelotl reopened this Feb 16, 2021
@ocelotl
Copy link
Contributor Author

ocelotl commented Feb 16, 2021

I think the changes here are ok. I'm curious though, it feels weird to have to import a util package for the only methods in propagators that we care about inject & extract

Any thoughts?

Yes, it is weird. How about renaming util to something more propagator-related like propagate?

@ocelotl ocelotl force-pushed the issue_1590 branch 2 times, most recently from 226fbfb to 149fa2b Compare February 16, 2021 17:55
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This is needed to make the PR pass its tests in CI. This requires the
version to be updated back later in a separate PR.
@lzchen lzchen merged commit ea9e933 into open-telemetry:main Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make propagators a namespace
4 participants