require dependency for api/sdk to match major version #1933
Conversation
codeboten
requested review from
a team,
aabmass and
ocelotl
and removed request for
a team
Agreed, approving still since this fixes the corresponding issue. ✌️ |
@owais Are you suggesting we change the dependency to |
scripts/proto_codegen_jaeger.sh
Outdated
| # | ||
| # Regenerate python code from Jaeger protos in | ||
| # https://github.com/jaegertracing/jaeger-idl | ||
| # |
There was a problem hiding this comment.
Submitted by accident. It's a script to regenerate jaeger protos. not needed for this PR.
| @@ -40,7 +40,7 @@ package_dir= | |||
| =src | |||
| packages=find_namespace: | |||
| install_requires = | |||
| opentelemetry-api == 1.4.0.dev0 | |||
| opentelemetry-api ~= 1.3 | |||
There was a problem hiding this comment.
Is this change only for packages upon release? Packages in development will still pin exact versions right?
There was a problem hiding this comment.
The plan is to unpin packages in development as well. If a dev package needs a new version of the api, then the dependency will need to be updated for that package at that time.
Description
This changes the dependency for packages to match the major version for API and SDK packages. This allows users more freedom to use packages with various versions, including experimental ones. I've left pinned version for specific packages that I think will still need specific versions. But after this change has been merged and the next version released, I think we should be able to move away from having to release all packages with every release and only release packages for code that has changed.
Fixes #1924
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: