-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated release workflow #2649
Conversation
This is nice |
I should have mentioned, I tested all of these workflows on my python repo fork, though there may still be a hiccup or two on the first try here. I'd be happy to coordinate and be online with you during the first release using these new workflows if you are interested. |
Sorry I haven't gotten a time to review this in detail but there are many things I like about this. Team has been focused on getting the rc for metrics work for the past few weeks. So it might take sometime before we review and get it merged. |
@lzchen thanks for all the comments! I have made several updates and I think replied to all of your comments, happy to make further updates |
@trask will it be possible for you to attend tomorrow python SIG meeting and present it to all? |
yes, I'll plan on it, would it work to join at 9:30am Pacific Time? |
That should work |
Will be approving after the |
I updated the workflow to work with "pre-release" versions, e.g. "1.13.0rc", and tested making a "pre-release" in https://github.com/trask/repository-template/releases/tag/v1.1.0rc. I'll re-test the full workflow in my
|
0f0070a
to
69e3a5f
Compare
Rebased and re-tested the release process (both minor and patch) in my fork. I realized that the backport automation (for patches) will fail currently most of the time due to change log conflicts. I think I can make the backport automation smarter and handle that, but I don't think it's necessarily required for landing this PR, as backports for patch releases can still be done manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, We will need to do this for contrib as well, not necessarily immediately.
Ah I see the failed jobs are because the contrib versions are not |
@srikanthccv |
…etry-python into release-workflow
I was talking about the
Yes. |
Hey all!
We've spent a lot of time lately improving our release workflow in the OTel Java repos, and I'd like to see if our toil and pain can be of any benefit to other repos (starting with python of course!).
I also think there's some benefit of shared cross-SIG knowledge going forward if we follow somewhat similar workflow practices.
I've tried to document things here: https://github.com/trask/repository-template/blob/main/template-docs/release-automation.md
Some highlights in this PR:
-dev
version suffix onmain
(@lzchen mentioned you were thinking about doing this anyways)github-actions[bot]
to EasyCLA allowlist community#809 (comment) (maybe we should consider creating a shared otel bot that all repos could use?)release/v1.12.x-0.31bx
), and patch releases are made out of those same branches. Tags are still applied to each individual release.New complications in this repo that we hadn't faced in the Java repos:
Skip Changelog
label to the generated pull requests that targetmain
, but that requires giving the bot triage rights to the repo, so instead suppressed the changelog workflow whengithub.actor
is the bot.I'd love to stop by your SIG meeting, but it's always at the same time as the Java SIG 😢. Maybe next week I can sneak away and jump to your meeting for a bit.
Please throw your questions this way though, I'd love to better understand where we can align more, and where things will naturally diverge based on SIG needs/preferences.