Create a single resource instance #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketmehta28
suggested changes
Jan 11, 2023
lzchen
approved these changes
Jan 11, 2023
ocelotl
approved these changes
Feb 2, 2023
|
@sanketmehta28 reminder, please review again. |
sanketmehta28
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This doesn't make much difference as of now, but when the
Resource.createimplementation starts to create new IDs for the uniqueness guarantees (exservice.instance.id), It will end up creating three different ids each for signal.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e opentelemetry-sdkDoes This PR Require a Contrib Repo Change?
Checklist: