fix: export ExponentialBucketHistogramAggregation from opentelemetry.sdk.metrics.view #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdk.metrics.view Without this PR if one wants to use exponential histrograms, which were added in realease 1.17.0 (https://github.com/open-telemetry/opentelemetry-python/blob/main/CHANGELOG.md#version-1170038b0-2023-03-22), one needs to import it from the private package opentelemetry.sdk.metrics._internal.aggregation. This PR fixes open-telemetry#3239.
ocelotl
approved these changes
Mar 27, 2023
lzchen
approved these changes
Mar 28, 2023
|
@sk this is a bugfix that users can see, please add a changelog entry. |
auto-merge was automatically disabled
March 29, 2023 00:35
Head branch was pushed to by a user without write access
ocelotl
approved these changes
Mar 29, 2023
|
Tests seem to be stuck on "Expected — Waiting for status to be reported" for some reason, investigating... |
|
@sk- can you try rebasing your branch against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this PR if one wants to use exponential histrograms, which were added in realease 1.17.0 (https://github.com/open-telemetry/opentelemetry-python/blob/main/CHANGELOG.md#version-1170038b0-2023-03-22), one needs to import it from the private package opentelemetry.sdk.metrics._internal.aggregation.
Fixes #3239
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: